Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crunchy-cli: deprecate #177559

Merged
merged 1 commit into from
Jul 17, 2024
Merged

crunchy-cli: deprecate #177559

merged 1 commit into from
Jul 17, 2024

Conversation

samford
Copy link
Member

@samford samford commented Jul 16, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The GitHub repository for crunchy-cli was archived on 2024-07-04. Before this, the README was updated to contain the following message:

This project has been sunset as Crunchyroll moved to a DRM-only system. See crunchy-labs/crunchy-cli#362.

This deprecates the formula accordingly.


Looking at the linked issue, it sounds like the software isn't functional anymore due to Crunchyroll changes, so I'm not sure if this would be a scenario where we disable the formula instead.

The GitHub repository for `crunchy-cli` was archived on 2024-07-04.
Before this, the `README` was updated to contain the following
message:

> This project has been sunset as Crunchyroll moved to a DRM-only
> system. See crunchy-labs/crunchy-cli#362.

This deprecates the formula accordingly.
@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue formula deprecated Formula deprecated ffmpeg FFMPEG use is a significant feature of the PR or issue labels Jul 16, 2024
@p-linnane p-linnane added the CI-no-bottles Merge without publishing bottles label Jul 16, 2024
@p-linnane p-linnane enabled auto-merge July 16, 2024 21:50
@p-linnane p-linnane added this pull request to the merge queue Jul 17, 2024
Merged via the queue into master with commit d73f60c Jul 17, 2024
22 checks passed
@p-linnane p-linnane deleted the crunchy-cli-deprecate branch July 17, 2024 02:45
@bytedream
Copy link

Looking at the linked issue, it sounds like the software isn't functional anymore due to Crunchyroll changes, so I'm not sure if this would be a scenario where we disable the formula instead.

(former) maintainer here. The commands that were used by the vast majority of people (-> downloading videos) doesn't work anymore. There is a command left which crawls metadata that isn't affected by the changes, so deprecating the formula instead of disabling was probably the better choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles ffmpeg FFMPEG use is a significant feature of the PR or issue formula deprecated Formula deprecated rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants