-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emp: use TCPServer instead of WEBrick for test #162041
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
go
Go use is a significant feature of the PR or issue
label
Feb 7, 2024
chenrui333
reviewed
Feb 7, 2024
github-actions
bot
added
the
autosquash
Automatically squash pull request commits according to Homebrew style.
label
Feb 7, 2024
|
Related to remind101/empire#1167 |
SMillerDev
reviewed
Feb 7, 2024
Merged
github-actions
bot
removed
the
autosquash
Automatically squash pull request commits according to Homebrew style.
label
Feb 10, 2024
alebcay
changed the title
emp: revision bump (go 1.21.7)
emp: use TCPServer instead of WEBrick for test
Feb 10, 2024
alebcay
added
CI-no-bottles
Merge without publishing bottles
and removed
test failure
CI fails while running the test-do block
labels
Feb 10, 2024
If this works then a similar fix should probably be applied also to few other formulae. |
cc @p-linnane & @iMichka |
SMillerDev
approved these changes
Feb 15, 2024
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CI-no-bottles
Merge without publishing bottles
go
Go use is a significant feature of the PR or issue
outdated
PR was locked due to age
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
both have a problem with webrick test:
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?