Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emp: use TCPServer instead of WEBrick for test #162041

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Feb 7, 2024

Related:

both have a problem with webrick test:

  An exception occurred within a child process:
    LoadError: cannot load such file -- webrick

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Feb 7, 2024
@stefanb stefanb mentioned this pull request Feb 7, 2024
1 task
Formula/e/emp.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Feb 7, 2024
@chenrui333
Copy link
Member

  ==> Testing emp
  Error: emp: failed
  An exception occurred within a child process:
    LoadError: cannot load such file -- webrick

@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Feb 7, 2024
@SMillerDev
Copy link
Member

Related to remind101/empire#1167

Formula/e/emp.rb Outdated Show resolved Hide resolved
@stefanb stefanb mentioned this pull request Feb 7, 2024
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Feb 10, 2024
@alebcay alebcay changed the title emp: revision bump (go 1.21.7) emp: use TCPServer instead of WEBrick for test Feb 10, 2024
@alebcay alebcay added CI-no-bottles Merge without publishing bottles and removed test failure CI fails while running the test-do block labels Feb 10, 2024
@stefanb
Copy link
Member Author

stefanb commented Feb 10, 2024

If this works then a similar fix should probably be applied also to few other formulae.

@stefanb
Copy link
Member Author

stefanb commented Feb 13, 2024

cc @p-linnane & @iMichka

@SMillerDev SMillerDev added this pull request to the merge queue Feb 15, 2024
Merged via the queue into Homebrew:master with commit 483a97b Feb 15, 2024
20 checks passed
@stefanb stefanb deleted the patch-2 branch February 15, 2024 12:38
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants