Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected]: clean up caveats #159435

Merged
merged 1 commit into from
Jan 9, 2024
Merged

[email protected]: clean up caveats #159435

merged 1 commit into from
Jan 9, 2024

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Follow up from #158215 per @Bo98.

@p-linnane p-linnane added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jan 9, 2024
@github-actions github-actions bot added legacy Relates to a versioned @ formula rust Rust use is a significant feature of the PR or issue labels Jan 9, 2024
@Bo98
Copy link
Member

Bo98 commented Jan 9, 2024

Thanks! Might be worth aligning the tests with the other versioned formulae in #159398 but up to you.

@p-linnane p-linnane added this pull request to the merge queue Jan 9, 2024
Merged via the queue into Homebrew:master with commit 4a3fbe5 Jan 9, 2024
14 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. legacy Relates to a versioned @ formula outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants