Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biosig: use tinyxml2 #159362

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jan 8, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Split out from #119829.

@scpeters scpeters mentioned this pull request Jan 8, 2024
6 tasks
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @scpeters!

@scpeters
Copy link
Member Author

scpeters commented Jan 8, 2024

rarian build works on macOS but fails on Linux

@p-linnane p-linnane added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jan 8, 2024
@p-linnane
Copy link
Member

Rerunning with no-fail-fast so we can see everything and debug from there.

@scpeters
Copy link
Member Author

scpeters commented Jan 8, 2024

rarian build works on macOS but fails on Linux

ok, I was wrong about rarian. I was testing on my local machine that still had tinyxml installed and linked in the background. Unlinking tinyxml shows the same failure. I'll redact rarian from this PR, since I think biosig does still work

@scpeters scpeters changed the title biosig, rarian: use tinyxml2 biosig: use tinyxml2 Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 8, 2024

🤖 An automated task has requested bottles to be published to this PR.

@p-linnane p-linnane removed the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jan 8, 2024
@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 8, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 8, 2024
Merged via the queue into Homebrew:master with commit 0e00114 Jan 8, 2024
12 checks passed
@scpeters scpeters deleted the chore/tinyxml/migrate branch January 8, 2024 23:27
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants