Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urls: prefer /archive/refs/tags urls over /archive #152092

Merged
merged 1,841 commits into from
Oct 23, 2023

Conversation

chenrui333
Copy link
Member

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 22, 2023
@chenrui333 chenrui333 requested a review from Bo98 October 22, 2023 21:42
@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Oct 22, 2023
Formula/b/boolector.rb Outdated Show resolved Hide resolved
Formula/c/caffe.rb Outdated Show resolved Hide resolved
Formula/d/dashing.rb Outdated Show resolved Hide resolved
Formula/l/luajit.rb Outdated Show resolved Hide resolved
@Bo98
Copy link
Member

Bo98 commented Oct 22, 2023

+ many more - I didn't check them all, only A-D + LuaJIT.

As I said in Homebrew/brew#16126 (comment), this is wrong for commit URLs and the regex needs updating to exclude them (e.g. any that's exclusively [0-9a-f])

@chenrui333
Copy link
Member Author

make sense

@chenrui333
Copy link
Member Author

excluded all the commit sha tgz urls from the changeset (and updated the audit regex in the brew side)

@chenrui333
Copy link
Member Author

  • ran brew fetch for the changeset, no checksum mismatch found
  • reverted some changes for repo_removed formulae (like neovide and nethacked)

@SMillerDev
Copy link
Member

This really shouldn't all be in one commit.

@chenrui333
Copy link
Member Author

This really shouldn't all be in one commit.

yeah, I was thinking about to do something similar to #139592

it is mostly style changes though, I can go either way.

@Bo98
Copy link
Member

Bo98 commented Oct 23, 2023

yeah, I was thinking about to do something similar to #139592

Plan was to rewrite history after that PR and it was useful at that point in time to have a single point in Git history that denoted the change, but history rewriting never happened in the end.

I wouldn't use that PR as precedence - it was a bit of a special PR that required temporarily changing repository settings to merge and doesn't match how we typically do brew style --fix PRs.

@chenrui333
Copy link
Member Author

ok, let me spread the commits then :)

@chenrui333
Copy link
Member Author

spreading the commits might too large for merge still, I will break down the PR alphabetically

@MikeMcQuaid
Copy link
Member

spreading the commits might too large for merge still

why would it be?

@chenrui333
Copy link
Member Author

spreading the commits might too large for merge still

why would it be?

it would be just 1800 commits and hard to review?

@chenrui333
Copy link
Member Author

ok, I will provide two options :) (see how folks prefer)

…/archive` for github tarball url

Signed-off-by: Rui Chen <[email protected]>
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 23, 2023
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 23, 2023
@Bo98 Bo98 removed this pull request from the merge queue due to a manual request Oct 23, 2023
@Bo98 Bo98 merged commit 544f27e into Homebrew:master Oct 23, 2023
14 checks passed
@chenrui333 chenrui333 deleted the github/update-artifact-urls branch October 23, 2023 15:01
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants