-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
urls: prefer /archive/refs/tags
urls over /archive
#152092
urls: prefer /archive/refs/tags
urls over /archive
#152092
Conversation
f18c127
to
6704cad
Compare
+ many more - I didn't check them all, only A-D + LuaJIT. As I said in Homebrew/brew#16126 (comment), this is wrong for commit URLs and the regex needs updating to exclude them (e.g. any that's exclusively |
make sense |
6704cad
to
9c95ed1
Compare
excluded all the commit sha tgz urls from the changeset (and updated the audit regex in the brew side) |
9c95ed1
to
d25c7ea
Compare
|
This really shouldn't all be in one commit. |
yeah, I was thinking about to do something similar to #139592 it is mostly style changes though, I can go either way. |
Plan was to rewrite history after that PR and it was useful at that point in time to have a single point in Git history that denoted the change, but history rewriting never happened in the end. I wouldn't use that PR as precedence - it was a bit of a special PR that required temporarily changing repository settings to merge and doesn't match how we typically do |
ok, let me spread the commits then :) |
spreading the commits might too large for merge still, I will break down the PR alphabetically |
why would it be? |
it would be just 1800 commits and hard to review? |
ok, I will provide two options :) (see how folks prefer) |
…or github tarball url Signed-off-by: Rui Chen <[email protected]>
…tarball url Signed-off-by: Rui Chen <[email protected]>
…tarball url Signed-off-by: Rui Chen <[email protected]>
…b tarball url Signed-off-by: Rui Chen <[email protected]>
…b tarball url Signed-off-by: Rui Chen <[email protected]>
…thub tarball url Signed-off-by: Rui Chen <[email protected]>
…github tarball url Signed-off-by: Rui Chen <[email protected]>
…arball url Signed-off-by: Rui Chen <[email protected]>
…rball url Signed-off-by: Rui Chen <[email protected]>
…rball url Signed-off-by: Rui Chen <[email protected]>
…ball url Signed-off-by: Rui Chen <[email protected]>
…b tarball url Signed-off-by: Rui Chen <[email protected]>
…thub tarball url Signed-off-by: Rui Chen <[email protected]>
… for github tarball url Signed-off-by: Rui Chen <[email protected]>
… github tarball url Signed-off-by: Rui Chen <[email protected]>
…github tarball url Signed-off-by: Rui Chen <[email protected]>
…/archive` for github tarball url Signed-off-by: Rui Chen <[email protected]>
…` for github tarball url Signed-off-by: Rui Chen <[email protected]>
…for github tarball url Signed-off-by: Rui Chen <[email protected]>
…ball url Signed-off-by: Rui Chen <[email protected]>
…all url Signed-off-by: Rui Chen <[email protected]>
d25c7ea
to
e51a887
Compare
unblocks Homebrew/brew#16126