Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bashunit 0.8.0 (new formula) #150207

Merged
merged 2 commits into from
Oct 9, 2023
Merged

bashunit 0.8.0 (new formula) #150207

merged 2 commits into from
Oct 9, 2023

Conversation

Chemaclass
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with
    HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source bashunit?
  • Is your test running fine brew test bashunit?
  • Does your build pass brew audit --strict bashunit?
    If this is a new formula, does it pass brew audit --new bashunit?
Screenshot 2023-10-08 at 22 46 18

@Chemaclass Chemaclass requested review from MikeMcQuaid and a team as code owners October 8, 2023 20:48
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. and removed workflows PR modifies GitHub Actions workflow files labels Oct 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Oct 8, 2023
@chenrui333 chenrui333 changed the title Add bashunit bashunit 0.8.0 (new formula) Oct 8, 2023
@chenrui333 chenrui333 added no long build conflict Do not allow merging other pull requests when files conflict with this one new formula PR adds a new formula to Homebrew/homebrew-core and removed no long build conflict Do not allow merging other pull requests when files conflict with this one labels Oct 8, 2023
@chenrui333
Copy link
Member

@Chemaclass thanks for your first PR to homebrew-core, can you amend your commit as the PR title. Thanks!

@chenrui333 chenrui333 added the almost there PR is nearly ready to merge label Oct 8, 2023
@chenrui333 chenrui333 force-pushed the add-bashunit branch 2 times, most recently from 17376c4 to a474c11 Compare October 8, 2023 23:44
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 8, 2023
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 8, 2023
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed almost there PR is nearly ready to merge automerge-skip `brew pr-automerge` will skip this pull request labels Oct 8, 2023
p-linnane
p-linnane requested changes Oct 9, 2023
View reviewed changes
Formula/b/bashunit.rb Show resolved Hide resolved
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 9, 2023
@Chemaclass @chenrui333
bashunit 0.8.0 (new formula)
f334761 
Signed-off-by: Rui Chen <[email protected]>

bashunit: add version check

Signed-off-by: Rui Chen <[email protected]>
@chenrui333
Copy link
Member

Since this is shell script, we can just use the consolidated one in the release artifact, it is pretty much the same as the one in the tarball file.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

:shipit: @p-linnane has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 9, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 9, 2023
Merged via the queue into Homebrew:master with commit 7c981e4 Oct 9, 2023
13 checks passed
@Chemaclass Chemaclass deleted the add-bashunit branch October 9, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@p-linnane p-linnane p-linnane approved these changes

@MikeMcQuaid MikeMcQuaid Awaiting requested review from MikeMcQuaid MikeMcQuaid is a code owner

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green workflows PR modifies GitHub Actions workflow files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chemaclass @chenrui333 @p-linnane @BrewTestBot