Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smake: update homepage, version #149711

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

samford
Copy link
Member

@samford samford commented Oct 5, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This brings smake in line with recent changes in the star formula (#149240). As discussed in the star PR, using the upstream date version:

  • Allows us to avoid a livecheck block (which involves a complex strategy block if we use a two-part version format)
  • Allows us to add related formulae to synced_versions_formulae.json
  • Better aligns with what the maintainer is doing in the FreeBSD port

@samford samford added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 5, 2023
@samford
Copy link
Member Author

samford commented Oct 5, 2023

For what it's worth, I encountered the following error when trying to build this locally (macOS Sonoma, ARM64):

ld: Undefined symbols:
  _libintl_setlocale, referenced from:
      _main in make.o

I'm not quite sure why it fails locally but passes on CI, though.

@alebcay
Copy link
Member

alebcay commented Oct 5, 2023

I found that it does the same on Monterey Intel, but works when I brew unlink gettext. My guess is that there's some opportunistic detection happening, such that the headers are found but libraries aren't in the search path.

That would explain why it works in CI - gettext is not a dependency so it is not present on the machine.

@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Oct 9, 2023
@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Oct 19, 2023
@chenrui333 chenrui333 added this pull request to the merge queue Oct 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 19, 2023
@samford samford removed the CI-no-bottles Merge without publishing bottles label Oct 19, 2023
@samford
Copy link
Member Author

samford commented Oct 19, 2023

We will need bottles for the date-only version, so CI-no-bottles doesn't seem appropriate here, correct?

I rebased this to see if it sorts out the issue with merging.

This brings `smake` in line with recent changes in the `star` formula.
Using the upstream date version:

* Allows us to avoid a `livecheck` block (which involves a complex
  `strategy` block if we use a two-part version format)
* Allows us to add related formulae to `synced_versions_formulae.json`
* Better aligns with what the maintainer is doing in the FreeBSD port
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 19, 2023
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 19, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 19, 2023
Merged via the queue into Homebrew:master with commit 81fbb41 Oct 19, 2023
12 checks passed
@samford samford deleted the smake-update-version branch October 20, 2023 01:37
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants