-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smake: update homepage, version #149711
smake: update homepage, version #149711
Conversation
For what it's worth, I encountered the following error when trying to build this locally (macOS Sonoma, ARM64):
I'm not quite sure why it fails locally but passes on CI, though. |
I found that it does the same on Monterey Intel, but works when I That would explain why it works in CI - |
be2ced7
to
5b5070d
Compare
We will need bottles for the date-only version, so I rebased this to see if it sorts out the issue with merging. |
This brings `smake` in line with recent changes in the `star` formula. Using the upstream date version: * Allows us to avoid a `livecheck` block (which involves a complex `strategy` block if we use a two-part version format) * Allows us to add related formulae to `synced_versions_formulae.json` * Better aligns with what the maintainer is doing in the FreeBSD port
5b5070d
to
5813ee5
Compare
🤖 An automated task has requested bottles to be published to this PR. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?This brings
smake
in line with recent changes in thestar
formula (#149240). As discussed in thestar
PR, using the upstream date version:livecheck
block (which involves a complexstrategy
block if we use a two-part version format)synced_versions_formulae.json