workflows/triage: update regex for no ARM bottle
#147591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
automerge-skip
fxcoudert
approved these changes
Sep 30, 2023
ZhongRuoyu
commented
Sep 30, 2023
.github/workflows/triage.yml
Outdated
| content: '\n sha256.* big_sur: +"[a-fA-F0-9]+"\n' | ||
| missing_content: '\n sha256.* arm64_big_sur: +"[a-fA-F0-9]+"\n' | ||
| content: '\n sha256.* (?!.*(?:arm64_|_linux)).+: +"[a-fA-F0-9]+"\n' | ||
| missing_content: '\n sha256.* arm64_(.+): +"[a-fA-F0-9]+"\n' |
There was a problem hiding this comment.
Didn't notice this initially but:
Suggested change
| missing_content: '\n sha256.* arm64_(.+): +"[a-fA-F0-9]+"\n' | |
| missing_content: '\n sha256.* arm64_.+: +"[a-fA-F0-9]+"\n' |
The current logic for `no ARM bottle` looks for Big Sur bottles, but Big Sur is no longer supported. This introduced false positives like To fix this and make it more future-proof, let's instead apply the `no ARM bottle` label whenever we see x86_64 macOS bottles but fail to find any arm64 ones. Regex reference: https://stackoverflow.com/a/37060970
ZhongRuoyu
force-pushed
the
triage-arm-bottles
branch
from
076ecf3
to
7029d21
Compare
fxcoudert
approved these changes
Sep 30, 2023
ZhongRuoyu
added a commit
to ZhongRuoyu/homebrew-core
that referenced
this pull request
Oct 1, 2023
In Homebrew#147591 I didn't take `all` bottles into account; the updated regex miscategorised e.g. Homebrew#148156. This fixes that.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?The current logic for
no ARM bottlelooks for Big Sur bottles, but Big Sur is no longer supported. This introduced false positives like #147570.To fix this and make it more future-proof, let's instead apply the
no ARM bottlelabel whenever we see x86_64 macOS bottles but fail to find any arm64 ones.Regex reference: https://stackoverflow.com/a/37060970