Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erlang@25: Workaround for Mac OS Sonoma #146286

Closed

Conversation

rafaelgaspar
Copy link

This basically disables JIT compiling for now since the way erlang@25 does JIT compiling is not supported by Mac OS Sonoma.

See this for more information: erlang/otp#7687

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the legacy Relates to a versioned @ formula label Sep 27, 2023
@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@rafaelgaspar
Copy link
Author

Tests are timing out while build the docs for CI / macOS 12-arm64.

@rafaelgaspar rafaelgaspar marked this pull request as ready for review September 27, 2023 17:24
@maxnordlund
Copy link
Contributor

This is only needed for ARM, so if would be nice if the JIT stays on x86. Not sure how to do that though.

This basically disables JIT compiling for now since the way erlang@25 does JIT compiling is not supported by Mac OS Sonoma.

See this for more information: erlang/otp#7687

erlang@25: disable JIT on arm64 Sonoma only
@p-linnane p-linnane added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 29, 2023
@p-linnane
Copy link
Member

I've pushed a change that limits disabling JIT to Apple Silicon only.

@rafaelgaspar
Copy link
Author

This will no longer be need with the next version.

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. legacy Relates to a versioned @ formula outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants