Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

triage(long build): add aws-sdk-cpp #140303

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

See:

@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 23, 2023
@chenrui333 chenrui333 requested review from MikeMcQuaid and a team as code owners August 23, 2023 18:32
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Aug 23, 2023
@p-linnane
Copy link
Member

Unthrottling here will put us on a weird version cadence. We should wait to unthrottle til we are back on multiples of 5.

@chenrui333
Copy link
Member Author

I think it is fine, we are not going to touch it until next time.

@chenrui333
Copy link
Member Author

actually you might be right, the audit would fail every single time, reverting that throttling change now.

@p-linnane p-linnane removed the automerge-skip `brew pr-automerge` will skip this pull request label Aug 23, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 23, 2023
Merged via the queue into Homebrew:master with commit 2c61566 Aug 23, 2023
16 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
@chenrui333 chenrui333 deleted the triage-update-20230823-p2 branch January 22, 2024 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants