Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-machine-parallels 2.0.1 (patch and build with go 1.20) #137195

Closed
wants to merge 4 commits into from

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Jul 21, 2023

Fix build on Go >= 1.20 by removing obsolete build flag "-i"

Uses patch from


Go 1.20 release notes:

The go build and go test commands no longer accept the -i flag, which has been deprecated since Go 1.16.


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue macos-only Formula depends on macOS labels Jul 21, 2023
@stefanb stefanb changed the title docker-machine-parallels (patch and build with go 1.20) docker-machine-parallels 2.0.1 (patch and build with go 1.20) Jul 21, 2023
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 21, 2023
@@ -5,6 +5,7 @@ class DockerMachineParallels < Formula
tag: "v2.0.1",
revision: "a1c3d495487413bdd24a562c0edee1af1cfc2f0f"
license "MIT"
revision 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since nothing changes for users I don't think this is needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx, removed it in 58d208cc9fef93ff3ae178ed6a2d90ebd09faf9d, since rebuild and update is not really required.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jul 21, 2023
@stefanb stefanb force-pushed the docker-machine-parallels branch from 58d208c to 6976ecb Compare July 21, 2023 10:39
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jul 21, 2023
SMillerDev
SMillerDev previously approved these changes Jul 21, 2023
@github-actions
Copy link
Contributor

🤖 An automated task has requested creation of a replacement PR.

@github-actions github-actions bot dismissed SMillerDev’s stale review July 21, 2023 11:53

Replacement PR dispatched

BrewTestBot pushed a commit that referenced this pull request Jul 21, 2023
* docker-machine-parallels (patch and build with go 1.20)
  Fix build on Go >= 1.20 by removing obsolete build flag "-i"
* full_index, sha256
* Fix trailing whitespace
* Removed redundant revision bump

Closes #137195.

Signed-off-by: BrewTestBot <[email protected]>
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request superseded PR was replaced by another PR labels Jul 21, 2023
@BrewTestBot BrewTestBot marked this pull request as draft July 21, 2023 11:54
@github-actions
Copy link
Contributor

✅ Replacement PR created at #137219.

github-merge-queue bot pushed a commit that referenced this pull request Jul 21, 2023
@stefanb stefanb deleted the docker-machine-parallels branch July 21, 2023 15:42
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue macos-only Formula depends on macOS outdated PR was locked due to age superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants