Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fnm 1.35.0 #136311

Merged
merged 2 commits into from
Jul 18, 2023
Merged

fnm 1.35.0 #136311

merged 2 commits into from
Jul 18, 2023

Conversation

Porkepix
Copy link
Contributor

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Jul 11, 2023
@chenrui333
Copy link
Member

chenrui333 commented Jul 11, 2023 •
edited
Loading 

Error: Failure while executing; `\{\"SHELL\"=\>\"bash\"\} /opt/homebrew/Cellar/fnm/1.35.0/bin/fnm completions --shell bash` exited with 101. Here's the output:

@chenrui333 chenrui333 added the build failure CI fails while building the software label Jul 11, 2023
@branchvincent
Copy link
Member

already reported: Schniz/fnm#1006

@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Jul 13, 2023
@chenrui333
Copy link
Member

closing for now.

@chenrui333 chenrui333 closed this Jul 14, 2023
@chenrui333
Copy link
Member

relates to #136514

@Porkepix @chenrui333
fnm 1.35.0
d0701a6 
fnm: add build patch for completion generation

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 reopened this Jul 17, 2023
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed build failure CI fails while building the software labels Jul 17, 2023
@chenrui333
Copy link
Member

adopted the patch, Schniz/fnm#1010 and it works for me.

@github-actions
Copy link
Contributor

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 18, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 18, 2023
Merged via the queue into Homebrew:master with commit e0c579d Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue upstream issue An upstream issue report is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Porkepix @chenrui333 @branchvincent @BrewTestBot