bwa: add arm64 support #100790
bwa: add arm64 support #100790
Conversation
BrewTestBot
added
deprecated license
Formula/bwa.rb
Outdated
| uses_from_macos "zlib" | ||
|
|
||
| def install | ||
| inreplace "ksw.c", "<emmintrin.h>", "<sse2neon.h>" if Hardware::CPU.arch == :arm64 |
There was a problem hiding this comment.
is there any upstream patch for this?
There was a problem hiding this comment.
Nope, as I think you've just realised. (Thanks for making a note though.) The project is not very actively maintained, although it's mature. Maybe we can make a note of that PR here, merge as-is, and then remove the inreplace once/if the bug-fix gets accepted and a new release made?
There was a problem hiding this comment.
yeah, if you can submit an upstream PR and add a code comment reference that, that would be great.
There was a problem hiding this comment.
There are 2 different upstream PRs, though both bundle corresponding library:
There was a problem hiding this comment.
@cho-m Yep. The first one is out-of-date and didn't work for me. The second is very simple and works fine. (Basically what I do with the inreplace.)
|
@cho-m Resolved. Should be read for merge now. |
|
🤖 A scheduled task has triggered a merge. |
Closes Homebrew#100790. Signed-off-by: Sean Molenaar <[email protected]> Signed-off-by: BrewTestBot <[email protected]>
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?