Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinyxml: deprecate #119829

Closed
Closed

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Waiting on ros/urdfdom#99 for urdfdom

@SMillerDev SMillerDev force-pushed the chore/tinyxml/deprecate branch 4 times, most recently from 25fc60e to 91218a4 Compare January 9, 2023 08:13
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Jan 9, 2023
@cho-m
Copy link
Member

cho-m commented Jan 10, 2023

Do we know status of ros/urdfdom#99? Last comment there was from over 3 years ago.

@SMillerDev
Copy link
Member Author

Yeah, that doesn't seem active anymore. I wonder if Homebrew could sponsor someone to work on that since the formula is too popular to deprecate I think.

@SMillerDev
Copy link
Member Author

Made ros/urdfdom#178 to continue that work. Another Homebrew maintainer @scpeters seems to work on some parts of urdfdom so I'm hoping for some assistance there.

@scpeters
Copy link
Member

Made ros/urdfdom#178 to continue that work. Another Homebrew maintainer @scpeters seems to work on some parts of urdfdom so I'm hoping for some assistance there.

sure thing I'll take a look

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Feb 8, 2023
@github-actions github-actions bot closed this Feb 15, 2023
@scpeters
Copy link
Member

scpeters commented Jan 7, 2024

the urdfdom formula has migrated to use tinyxml2, so this could be revisited

@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jan 8, 2024
@scpeters
Copy link
Member

scpeters commented Jan 8, 2024

it seems like the other formulae are picking up tinyxml anyway because it's installed due to being modified in this PR? Should we try to split out the commits that modify the tinyxml dependents into a separate PR?

@github-actions github-actions bot removed the stale No recent activity label Jan 8, 2024
@SMillerDev
Copy link
Member Author

Yeah, I think that would be best. Do you want to make a PR with the tinyxml > tinyxml2 changes @scpeters ? I'm not near a PC now.

@scpeters scpeters mentioned this pull request Jan 8, 2024
6 tasks
@scpeters
Copy link
Member

scpeters commented Jan 8, 2024

Yeah, I think that would be best. Do you want to make a PR with the tinyxml > tinyxml2 changes @scpeters ? I'm not near a PC now.

I've split out biosig and rarian in #159362

@scpeters
Copy link
Member

scpeters commented Jan 8, 2024

Yeah, I think that would be best. Do you want to make a PR with the tinyxml > tinyxml2 changes @scpeters ? I'm not near a PC now.

I've split out biosig and rarian in #159362

rarian was failing to build, so I just made the changes for biosig in #159362

@scpeters scpeters mentioned this pull request Jan 9, 2024
6 tasks
@scpeters
Copy link
Member

scpeters commented Jan 9, 2024

I've split out the openclonk deprecation into #159373

@scpeters
Copy link
Member

scpeters commented Jan 9, 2024

I've glanced at the rarian source code, and the ENABLE_SK_COMPAT option appears to use a vendored version of tinyxml, but it still fails while searching for tinyxml.h, so some further investigation is needed. I don't know autotools well enough to debug this further, but it may be a path to removing the tinyxml dependency.

https://github.com/0mp/rarian/blob/master/util/Makefile.am#L39-L49

@scpeters
Copy link
Member

I've glanced at the rarian source code, and the ENABLE_SK_COMPAT option appears to use a vendored version of tinyxml, but it still fails while searching for tinyxml.h, so some further investigation is needed. I don't know autotools well enough to debug this further, but it may be a path to removing the tinyxml dependency.

https://github.com/0mp/rarian/blob/master/util/Makefile.am#L39-L49

actually that's not the canonical repo for rarian. It looks like tinyxml was vendored as of 0.8.2, but it was removed in 0.8.3

@SMillerDev
Copy link
Member Author

Created https://gitlab.freedesktop.org/rarian/rarian/-/issues/9 for Rarian support.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Feb 1, 2024
@github-actions github-actions bot closed this Feb 8, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants