Skip to content

Commit

Permalink
workflows: fix bottle uploads for replacement PRs
Browse files Browse the repository at this point in the history
The empty string is falsey in JavaScript, so `--no-upload` is always
interpolated in the call to `brew pr-pull`. Let's fix that so that
`--no-upload` is passed only when the replacement PR is requested
without a bottle upload.
  • Loading branch information
carlocab committed Aug 15, 2023
1 parent cb19fea commit bbda183
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/create-replacement-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ jobs:
--committer="$BREWTESTBOT_NAME_EMAIL" \
--root-url="https://ghcr.io/v2/homebrew/core" \
${{ inputs.autosquash && '--autosquash' || '--clean --no-cherry-pick' }} \
${{ inputs.upload && '' || '--no-upload' }} \
${{ !inputs.upload && '--no-upload' || '' }} \
${{ inputs.warn_on_upload_failure && '--warn-on-upload-failure' || '' }} \
${{ inputs.message && '--message="$MESSAGE"' || '' }} \
"$PR"
Expand Down

0 comments on commit bbda183

Please sign in to comment.