1password: migrate casks (1) #172357
Merged
1password: migrate casks (1) #172357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 28, 2024
bevanjkay
reviewed
Apr 28, 2024
| @@ -16,8 +16,6 @@ | |||
| regex(%r{href=.*?/op_apple_universal[._-]v?(\d+(?:\.\d+)+)\.pkg}i) | |||
| end | |||
|
|
|||
| conflicts_with cask: "1password-cli1" | |||
There was a problem hiding this comment.
Why do these need to be removed and not changed?
There was a problem hiding this comment.
@bevanjkay, they're added back in #172356. The conflicting casks are not resolved in CI (See, e.g., https://github.com/Homebrew/homebrew-cask/actions/runs/8863512074/job/24337653300) and this is a workaround to migrating casks individually.
There was a problem hiding this comment.
The gather cask information step is loading the casks from the API, so even after a rebase, it would continue to fail until the API propagates.
It might be better to have a way to switch the gather cask information step to include the HOMEBREW_NO_INSTALL_FROM_API environment variable.
Can you help here @Bo98?
razvanazamfirei
force-pushed
the
migrate-1-password-no-conflict
branch
from
39d18d2 to
3980305
Compare
p-linnane
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
conflicts_with caskfrom this migration, will add back in a separate PR.The merge order is: