anythingllm 1.5.1 (new cask) #172271
Merged
anythingllm 1.5.1 (new cask) #172271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bevanjkay
reviewed
Apr 29, 2024
Casks/a/anything-llm.rb
Outdated
| url "https://s3.us-west-1.amazonaws.com/public.useanything.com/latest/AnythingLLMDesktop#{suffix}.dmg", | ||
| verified: "s3.us-west-1.amazonaws.com/public.useanything.com/" | ||
| name "AnythingLLM" | ||
| desc "All-in-one Desktop application with full RAG and AI Agent capabilities" |
There was a problem hiding this comment.
Can you try to provide an alternative that meets the desc stanza guidelines?
bevanjkay
reviewed
Apr 29, 2024
Casks/a/anything-llm.rb
Outdated
| @@ -0,0 +1,25 @@ | |||
| cask "anything-llm" do | |||
| arch arm: "aarch64", intel: "x86-64" | |||
There was a problem hiding this comment.
It doesn't look like these variables are used anywhere?
You should use the arch to define the variables in currently in suffix.
Also note that you can simply omit the intel conditional, as it will default to an empty string.
chenrui333
approved these changes
Apr 29, 2024
miccal
approved these changes
Apr 29, 2024
bevanjkay
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.