singlecrystal: 5.0.0 (new cask) #172225
Merged
singlecrystal: 5.0.0 (new cask) #172225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
samford
reviewed
Apr 26, 2024
There was a problem hiding this comment.
- I was unable to find a link like
https://crystalmaker.com/support/updates/VersionData-SGM.xml, please help me with the livecheck.
Looks like the URL is https://crystalmaker.com/support/updates/VersionData-SCM.xml. I pushed a commit to add a livecheck block, using the approach in https://github.com/Homebrew/homebrew-cask/pull/172222/files#r1581568335.
Past the livecheck block, I'll leave the overall cask review to our cask maintainers.
|
Ah, it was my oversight. Thank you so much @samford! |
razvanazamfirei
approved these changes
Apr 27, 2024
singularitti
changed the title
singlecrystal: 5.0.0 (new cask)
bevanjkay
approved these changes
Apr 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.