dev-cmd/livecheck: Skip autobumped formulae

[issyl0]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

• Fixes option to remove BrewTestBot checked formulae from brew livecheck output #18640.
• Skip formulae that are autobumped by BrewTestBot, to avoid useless effort spent by contributors who are checking for formulae to bump and then we close their PRs.
• ❓ I’m not sure how we use livecheck for the actual autobump process, hence why this is draft because this approach might break that.

[samford]

As this is currently implemented, users don't have a way to disable this filtering behavior other than manually modifying this code. livecheck blocks for autobumped formulae/casks regularly break, so we need a way to be able to run these checks locally for debugging/fixing. A CLI option to also check autobumped packages (e.g., --autobump) would be a simple addition.

Beyond that, there may be something to be said for also offering an environment variable that would act like --autobump is always used (e.g., HOMEBREW_LIVECHECK_AUTOBUMP). My situation may be a bit rare (since I do a lot of livecheck block maintenance) but I almost never want to skip autobumped packages, so I would greatly prefer to not have to add a CLI option a lot of the time (and having to completely re-do long runs if I forget).

[samford]

If we add a way to disable this filtering behavior, this statement may not always be true. It may be better to simply leave out this added language (i.e., overarching assumptions about what livecheck will/won't check apply here).

[issyl0]

Suggested change

	`~/.homebrew/livecheck_watchlist.txt`, excluding autobumped formulae.
	`~/.homebrew/livecheck_watchlist.txt`.

[samford]

I don't think this logic will work as intended if a formula and cask both share the same name and the formula/cask is only in one of the autobump lists. For example, if the cask is in its autobump list but the formula isn't, the formula would still be skipped like the cask. Instead, we should only be checking the autobump file from the formula_or_cask tap.

I could be wrong but it may be technically possible for a tap other than core/cask to have an autobump.txt file and it seems like we would want to respect that in the same way. Either way, we could take a more generic approach instead of special-casing first-party taps. You may be able to borrow some ideas from Livecheck::load_other_tap_strategies (omitting the logic to skip first-party taps, of course).

The basic idea is to identify the taps that are in use for formulae_and_casks_to_check and then gather the autobump files, mapping them to the tap (as before, only doing this once before filtering packages).

[issyl0]

Ah, thanks for reminding me of packages with the same name in both core and cask!

[MikeMcQuaid]

Suggested change

	autobump_core = File.read(autobump_core_path).lines.map(&:strip)
	autobump_cask = File.read(autobump_cask_path).lines.map(&:strip)
	autobump_core = autobump_core_path.read.lines.map(&:strip)
	autobump_cask = autobump_cask_path.read.lines.map(&:strip)

or .readlines may make sense

[MikeMcQuaid]

Suggested change

	@autobump_core_path ||= T.let(Tap.fetch("homebrew/core").path/".github/autobump.txt", T.nilable(Pathname))
	@autobump_core_path ||= T.let(Tap.fetch("homebrew/core").path/".github/autobump.txt", Pathname)

maybe?

[issyl0]

OK, thanks @samford! I’ll add HOMEBREW_LIVECHECK_AUTOBUMP and an —-autobump flag or something similarly named.