Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BundleVersion comparison when short_version is not comparable #18598

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

khipp
Copy link
Member

@khipp khipp commented Oct 21, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR fixes an issue when comparing two BundleVersion objects where the version variables are equal and the short_version variables are nil. In this case, the result of the initial version comparison should be returned.

Before:

$ brew livecheck --cask teamviewer
Error: teamviewer: comparison of Array with Array failed

After:

$ brew livecheck --cask teamviewer
teamviewer: 15.58.4 ==> 15.58.4

@khipp khipp force-pushed the fix-bundle-version-comparison branch from 2207142 to 773242b Compare October 21, 2024 15:31
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @khipp!

@MikeMcQuaid MikeMcQuaid merged commit a74bdb2 into Homebrew:master Oct 21, 2024
27 checks passed
@khipp khipp deleted the fix-bundle-version-comparison branch October 21, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants