Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env to disable finding packages from paths #17840

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Jul 24, 2024

We have HOMEBREW_ALLOWED_TAPS but this is currently bypassable by manually downloading and doing brew install ./something.rb

Add a new env to disable this functionality. Unfortunately, a lot of things uses this internally so have to allow HOMEBREW_CELLAR etc. for now (though such environments should be protected anyway in controlled environments).

Naming open to debate.

@Bo98 Bo98 mentioned this pull request Jul 24, 2024
@Bo98 Bo98 force-pushed the forbid-path-installs branch 2 times, most recently from 358f278 to 828790b Compare July 24, 2024 05:45
@MikeMcQuaid
Copy link
Member

This looks great, thanks again @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit b31cfe8 into master Jul 25, 2024
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the forbid-path-installs branch July 25, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants