Fix completion generation for --repository
#17728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
previously approved these changes
Jul 14, 2024
MikeMcQuaid
reviewed
Jul 14, 2024
There was a problem hiding this comment.
@ZhongRuoyu This doesn't seem like what we want unfortunately 🙃
|
Looks like our completions setup doesn't understand the new bash |
|
Yea, unfortunately, it seems our completion generator is not able to handle Bash commands like that... |
|
@ZhongRuoyu A workaround for now would be to keep the Ruby file around just for fixing the completions. Could just make it |
ZhongRuoyu
force-pushed
the
sponsors-maintainers-man-completions
branch
from
bbd5d3f
to
901f910
Compare
I used $ brew --repo homebrew/core
Error: StandardError
Warning: Removed Sorbet lines from backtrace!
Rerun with `--verbose` to see the original backtrace
/usr/local/Homebrew/Library/Homebrew/cmd/--repository.rb:29:in `run'
/usr/local/Homebrew/Library/Homebrew/brew.rb:95:in `<main>'
Please report this issue:
https://docs.brew.sh/Troubleshooting |
ZhongRuoyu
changed the title
--repository
MikeMcQuaid
reviewed
Jul 14, 2024
MikeMcQuaid
approved these changes
Jul 14, 2024
|
Thanks @ZhongRuoyu! |
ZhongRuoyu
reviewed
Jul 14, 2024
ZhongRuoyu
force-pushed
the
sponsors-maintainers-man-completions
branch
from
3d9879f
to
8ae18f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autogenerated by the sponsors-maintainers-man-completions workflow.