Portable Ruby 3.3.1

[MikeMcQuaid]

Use the latest version of Portable Ruby.

I may have missed some stuff here.

May need new checksums once https://github.com/Homebrew/homebrew-portable-ruby/actions/runs/9105311684 completes.

[Bo98]

If we're deleting 3.1 vendored gems may need to bump HOMEBREW_REQUIRED_RUBY_VERSION, which is technically a breaking change but let's pretend we didn't miss 4.3.0.

[MikeMcQuaid]

If we're deleting 3.1 vendored gems may need to bump HOMEBREW_REQUIRED_RUBY_VERSION, which is technically a breaking change but let's pretend we didn't miss 4.3.0.

Yeh, might just retrospectively add to the notes there if I can get this merged 🔜 and note it'll land in 4.3.1.

[Bo98]

Pathname#rmtree now never returning errors is a horrifically subtle change that questions the safety of every #rmtree call we have, given the new behaviour now means rmtree can return without actually removing the directory (somewhat of a security risk potentially).

[Bo98]

e.g. this error catching now doesn't work:

brew/Library/Homebrew/reinstall.rb

Lines 73 to 78 in 97030b7

	backup_path(keg).rmtree if backup_path(keg).exist?
	rescue Errno::EACCES, Errno::ENOTEMPTY
	odie <<~EOS
	Could not remove #{backup_path(keg).parent.basename} backup keg! Do so manually:
	sudo rm -rf #{backup_path(keg)}
	EOS

We could override the behaviour in extend/pathname.rb. Seems hacky but might be the safest solution.

[MikeMcQuaid]

Yeh, good catch and idea here @Bo98.

[EricFromCanada]

Seeing the same test failure in 10.13 and up that was showing in CI earlier:

1) Cask::Artifact::App install_phase when the target already exists given the force option target is user-owned but contains read-only files overwrites the existing app
     Failure/Error: let(:install_phase) { app.install_phase(command:, adopt:, force:) }

     ErrorDuringExecution:
       Failure while executing; `/usr/bin/env touch /private/tmp/homebrew-tests-20240516-52284-zi9hyc/cask-appdir/Caffeine.app/.homebrew-write-test` exited with 1. Here's the output:
       touch: /private/tmp/homebrew-tests-20240516-52284-zi9hyc/cask-appdir/Caffeine.app/.homebrew-write-test: Permission denied

10.11 and 10.12 weren't able to install the required gems for brew tests.

[Bo98]

sorbet/sorbet#7895

[Bo98]

10.11 and 10.12 weren't able to install the required gems for brew tests.

I assume this was the case with Ruby 3.1.4 too?

[MikeMcQuaid]

Thanks for all the help here @Bo98 🎉