Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --display-times with --cask #17052

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

toobuntu
Copy link
Contributor

@toobuntu toobuntu commented Apr 9, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Options --cask and --display-times do not need to be mutually exclusive with brew install, brew reinstall and brew upgrade.

eb16e10 added recording of cask installation times but didn't update the conflicts.

install.rb had a faulty return if condition that prevented execution of periodic clean or displaying installation times in cask-only installs. This was because installed_formulae.empty? would always evaluate to true.

Ref: https://github.com/orgs/Homebrew/discussions/5262

brew typecheck on arm64 led me to this bug sorbet/sorbet#6778

- All dependencies satisfied message applies to both formulae and casks.
- Trigger the empty formulae return condition only if formulae are present.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks again for another great PR @toobuntu!

@MikeMcQuaid MikeMcQuaid merged commit 8acb03b into Homebrew:master Apr 9, 2024
25 checks passed
@toobuntu toobuntu deleted the relax-display-times branch April 9, 2024 11:10
@github-actions github-actions bot added the outdated PR was locked due to age label May 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants