Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sayonara Ruby 2.6 #16316

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Sayonara Ruby 2.6 #16316

merged 1 commit into from
Dec 12, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Dec 12, 2023 •
edited
Loading

Remove Ruby 2.6 & macOS system Ruby support code.

Separate from #16313 to reduce revert risk as reverting vendored gem changes can be problematic. The two PRs however can be merged at the same time.

Updating RuboCop's TargetRubyVersion will come later.

@Bo98 Bo98 mentioned this pull request Dec 12, 2023
Closed
11 tasks
MikeMcQuaid
MikeMcQuaid approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍🏻

@Bo98 Bo98 marked this pull request as ready for review December 12, 2023 16:15
@Bo98 Bo98 merged commit 6938fb7 into Homebrew:master Dec 12, 2023
32 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bo98 @MikeMcQuaid