Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/bump: indicate deprecated or skipped formulae/casks #16314

Conversation

EricFromCanada
Copy link
Member

@EricFromCanada EricFromCanada commented Dec 11, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This improves brew bump output by:

  • displaying "Latest livecheck version: skipped" if the livecheck is skipped for any reason
  • displaying "(deprecated)" next to the current formula or cask version for deprecated formulae or casks
  • displaying just "Cask is disabled" for disabled casks

This can be merged once #16292 is completed.

@EricFromCanada EricFromCanada changed the title bump: indicate deprecated or skipped formulae/casks cmd/bump: indicate deprecated or skipped formulae/casks Dec 11, 2023
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍🏻

@EricFromCanada EricFromCanada marked this pull request as ready for review December 17, 2023 21:55
@EricFromCanada EricFromCanada merged commit eb5f7fb into Homebrew:master Dec 18, 2023
24 checks passed
@EricFromCanada EricFromCanada deleted the bump-skipped-deprecated-disabled branch December 18, 2023 00:21
@MikeMcQuaid
Copy link
Member

Thanks @EricFromCanada!

@github-actions github-actions bot added the outdated PR was locked due to age label Jan 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants