Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency: disable renamed formula warning #16310

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

If a user has an older keg installed that refers to a dependency by an old name, after each install / uninstall / invocation of brew uses they'll see something like Warning: Formula atk was renamed to at-spi2-core. without context. I'm told this can be silenced since old names are symlinked anyway.

@EricFromCanada EricFromCanada marked this pull request as draft December 10, 2023 06:13
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for this @EricFromCanada!

@EricFromCanada EricFromCanada marked this pull request as ready for review December 11, 2023 19:15
@MikeMcQuaid MikeMcQuaid merged commit 4c20298 into Homebrew:master Dec 11, 2023
24 checks passed
@EricFromCanada EricFromCanada deleted the dependency-warn-false branch December 11, 2023 19:47
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants