Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump VENDOR_VERSION in gems.rb #16269

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Bump VENDOR_VERSION in gems.rb #16269

merged 1 commit into from
Nov 29, 2023

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Nov 29, 2023

Per the code comment, it seems I should bump this after ignoring a pair of committed vendored gems in #16259 :

https://github.com/Homebrew/brew/pull/16259/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947R102 https://github.com/Homebrew/brew/pull/16259/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947R109

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the workflow I have to check for this doesn't have the correct paths: triggers - I'll fix that!

@Bo98 Bo98 merged commit 8b2af53 into master Nov 29, 2023
27 checks passed
@Bo98 Bo98 deleted the dduugg-patch-1 branch November 29, 2023 18:15
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants