utils/analytics: don't fail on invalid version #16257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
approved these changes
Nov 27, 2023
MikeMcQuaid
reviewed
Nov 27, 2023
Bo98
force-pushed
the
analytics-version-fix
branch
from
59e49a6
to
1f483bf
Compare
carlocab
approved these changes
Nov 30, 2023
MikeMcQuaid
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Thanks @Bo98. Added a bump to brew.sh too just while we're here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the git repo is broken,
HOMEBREW_VERSIONcould be set to:brew/Library/Homebrew/brew.sh
Line 488 in 251a098
This causes an error in
utils/analyticswhich expectsHOMEBREW_VERSIONto match a regex, and therefore breaks any formula installs. Avoid that by defaulting to "unknown" if the fallback HOMEBREW_VERSION is detected.I've seen two reports of this in two days - not entirely sure why it's suddenly come up.