ENV/shared: fix macOS code not applying under HOMEBREW_SORBET_RUNTIME #16218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
added
the
critical
BrewTestBot
approved these changes
Nov 14, 2023
This was referenced Nov 14, 2023
Percona Toolkit fails on macOS 10.4 due to #!/usr/bin/perl5.34 shebang
Homebrew/homebrew-core#154201
Closed
|
Good catch, thanks @Bo98! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When redefining a method, Sorbet Runtime will not detect this properly if it does not have a type signature and the original did. This results in the new method being completely ignored and Sorbet only calling the original. I reckon is an upstream bug, but we can workaround it ourselves.
This fixes an important issue where any formulae using macOS Perl on Sonoma would not use the correct perl.