Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Refactor TapLoader to fix tap migrations with API" #16214

Closed
wants to merge 1 commit into from
Closed

Revert "Refactor TapLoader to fix tap migrations with API" #16214

wants to merge 1 commit into from

Conversation

MikeMcQuaid
Copy link
Member

CC @Rylan12

Reverts #16207
Fixes #16213

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Nov 13, 2023
@Bo98
Copy link
Member

Bo98 commented Nov 13, 2023

Will try #16215 as that seems to fix it.

@Bo98 Bo98 disabled auto-merge November 13, 2023 16:17
@Rylan12
Copy link
Member

Rylan12 commented Nov 13, 2023

Closing in favor of #16216. Will reopen if that PR doesn't go through

@Rylan12 Rylan12 closed this Nov 13, 2023
@Rylan12 Rylan12 deleted the revert-16207-api-tap-migrations branch November 13, 2023 19:13
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew install not respecting tap when formula name collides with core
4 participants
@MikeMcQuaid @Bo98 @Rylan12 @BrewTestBot