dev-cmd/livecheck: avoid watchlist in test #15881
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?The existing watchlist test in
test/dev-cmd/livecheck_spec.rb
will only pass if the testing environment doesn't contain a livecheck watchlist file. When a watchlist file is present, it ends up being treated as empty (formulae and casks aren't available in tests) and produces anInvalid usage: No formulae or casks to check
error instead. We don't have to worry about a watchlist file on CI but it's a potential issue when runningbrew test
locally.This provides a bogus
HOMEBREW_LIVECHECK_WATCHLIST
value to the#brew
call, to ensure that any watchlist file in the testing environment is not used for this test.For what it's worth, the test used to pass even if there was a watchlist file when the default location was
~/.brew_livecheck_watchlist
. This is because the home directory isHOMEBREW_PREFIX/Library/Homebrew/test/
in tests and there isn't a.brew_livecheck_watchlist
file there. The default livecheck watchlist path changed in #15787 such that it's now available in the testing environment, so now we encounter this issue.