Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

post_install: improvements and fixes. #15781

Merged
merged 1 commit into from
Jul 28, 2023
Merged

post_install: improvements and fixes. #15781

merged 1 commit into from
Jul 28, 2023

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 28, 2023 •
edited
Loading

  • warn if running brew postinstall explicitly and there's no post_install defined in the formula
  • add a post_install alias for brew postinstall to make life easier for those jumping between postinstall and post_install in e.g. Homebrew development
  • refactor post_install formula path logic into a new method for improved readability
  • handle the JSON API post_install formula path case

Fixes #15775

@MikeMcQuaid MikeMcQuaid mentioned this pull request Jul 28, 2023
Closed
4 tasks
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jul 28, 2023
@MikeMcQuaid
post_install: improvements and fixes.
7801878 
- warn if running `brew postinstall` explicitly and there's no
  `post_install` defined in the formula
- add a `post_install` alias for `brew postinstall` to make life
  easier for those jumping between `postinstall` and `post_install` in
  e.g. Homebrew development
- refactor `post_install` formula path logic into a new method for
  improved readability
- handle the JSON API `post_install` formula path case
@MikeMcQuaid MikeMcQuaid merged commit 389bcf4 into Homebrew:master Jul 28, 2023
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the post_install_improvements_fixes branch July 28, 2023 11:06
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve handling of stale homebrew/core clones
2 participants
@MikeMcQuaid @BrewTestBot