Skip to content

Commit

Permalink
Merge pull request #18675 from Homebrew/formula_auditor-pkgconf
Browse files Browse the repository at this point in the history
  • Loading branch information
p-linnane authored Nov 3, 2024
2 parents 6dffecd + 347e946 commit 4d0deeb
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions Library/Homebrew/formula_auditor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -361,8 +361,10 @@ def audit_deps
EOS
end

# we want to allow uses_from_macos for aliases but not bare dependencies
if self.class.aliases.include?(dep.name) && !dep.uses_from_macos?
# we want to allow uses_from_macos for aliases but not bare dependencies.
# we also allow `pkg-config` for backwards compatibility in external taps.
# TODO: after migrating all `pkg-config` usage to `pkgconf`, do not allow `pkg-config` in core tap
if self.class.aliases.include?(dep.name) && !dep.uses_from_macos? && dep.name != "pkg-config"
problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'."
end

Expand Down

0 comments on commit 4d0deeb

Please sign in to comment.