Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subgroup_group iso lemmas and all trivial subgroups are iso #2195

Merged
merged 6 commits into from
Jan 15, 2025
Merged

subgroup_group iso lemmas and all trivial subgroups are iso #2195

merged 6 commits into from
Jan 15, 2025

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Jan 15, 2025

  • subgroup_group is a (displayed) functor.
  • All trivial subgroups (of different groups) are isomorphic.

@Alizter Alizter requested a review from jdchristensen January 15, 2025 03:09
@Alizter
Copy link
Collaborator Author

Alizter commented Jan 15, 2025

@jdchristensen Your two suggestions were related, when I reorganised I saw that I could use istrivial_iff_grp_iso_trivial to prove both directions of grp_iso_trivial_subgroup.

@Alizter Alizter force-pushed the ps/rr/subgroup_group_iso_lemmas_and_all_trivial_subgroups_are_iso branch from eacc9f0 to 772137f Compare January 15, 2025 16:58
@Alizter
Copy link
Collaborator Author

Alizter commented Jan 15, 2025

I resolved the conflict and did a similar reorganisation for maximal subgroups. Hopefully the file is a bit clearer now. Since Subgroup.v grew quite organically, I should go through and help with the organisation a bit.

jdchristensen
jdchristensen approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@jdchristensen jdchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the last two changes to the comments.

theories/Algebra/Groups/Subgroup.v Outdated Show resolved Hide resolved
theories/Algebra/Groups/Subgroup.v Outdated Show resolved Hide resolved
@Alizter Alizter merged commit ef81e30 into HoTT:master Jan 15, 2025
20 checks passed
@Alizter Alizter deleted the ps/rr/subgroup_group_iso_lemmas_and_all_trivial_subgroups_are_iso branch January 15, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdchristensen jdchristensen jdchristensen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alizter @jdchristensen