Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strikethrough as text rendering option #305

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WaxCylinderRevival
Copy link
Member

Request @joewiz to investigate whether we need to add anything to stylesheets or tagsDecl for proper web rendering of strikethrough phrases

Thank you!

~ @WaxCylinderRevival and @KerryHite

…dwritten notes

Format and indent

---
Request @joewiz to investigate whether we need to add anything to stylesheets for proper web rendering of strikethrough phrases
@joewiz
Copy link
Member

joewiz commented Mar 9, 2022

@WaxCylinderRevival @KerryHite For strikethroughs we use <del rend="strikethrough">. For an example of usage in FRUS, see https://history.state.gov/historicaldocuments/frus1955-57v17/d255. For the TEI definition of the <del> element, see https://www.tei-c.org/release/doc/tei-p5-doc/en/html/ref-del.html. For discussion about it and related elements, https://www.tei-c.org/release/doc/tei-p5-doc/en/html/CO.html#COEDADD.

Does <del> as described here work for the cases before you?

@WaxCylinderRevival
Copy link
Member Author

Hi, @joewiz! Thank you for directing us to del. At our meeting today, @KerryHite and I agreed that the intent of the different strikes in the volume in question could be accurately represent by del.

EXAMPLE
We received this submission:
<item>word1 word2 <hi rend="strike">PHRASE</hi> word3 word4 PHRASE word5</item>

which we will direct to be corrected as:
<item>word1 word2 <del rend="strikethrough">PHRASE</hi> and word3 word4 PHRASE word5</item>

Questions for @joewiz :

  • Since the examples on https://www.tei-c.org/release/doc/tei-p5-doc/en/html/ref-del.html and https://www.tei-c.org/release/doc/tei-p5-doc/en/html/CO.html#COEDADD offer @rend values of "overstrike" and "overtype" rather than "strikethrough," could we add documentation in the FRUS schema to accept "strikethrough" as an acceptable del/@rend value?
  • If you agree that adding to the documentation would be helpful, would you like @WaxCylinderRevival to submit the additions in a pull request or would you like the Digital Initiatives team to do it?
    • I ran an XPath search over our frus repository in oXygenXML and found in 10,000+ instances of del, the only @rend value we've used so far appears to be strikethrough, but we may encounter other forms such as overstrike or overtype in the future. We could certainly define one, three, or more values in anticipation of their appearance.

Thank you again for your help!

~ @KerryHite and @WaxCylinderRevival

@WaxCylinderRevival
Copy link
Member Author

Hi, @joewiz,

Re-upping the questions in #305 (comment), in case they were buried in the email of our lives. ;-)

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants