-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closer structure and typography #293
Draft
vak2ve
wants to merge
34
commits into
master
Choose a base branch
from
closer-structure-and-typography
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes applied throughout including examples drawn from these volumes for new guidelines/visual style guide.
Fixes applied throughout to address inconsistencies in closer content noted by @KerryHite Mid-word line breaks also fixed
This reverts commit ec1f07b.
Fixes applied throughout to address inconsistencies in closer content noted by @KerryHite Mid-word line breaks reinstated. Thanks @joewiz!
Requires accompanying commit in hsg-project with the associated transformation scenario
more scenarios to file
closer error pattern fixes ongoing
xquery fixes for closer issues, ongoing
closer fix queries ongoing
signature-structures xquery in progress
typo and minor rend fixes to match new guidelines
xquery scripts test run on early frus volumes
on reagan-era and early FRUS volumes
all Reagan files updated with closer fixes based on fix-signature-structure.xq @joewiz query for persName insertion in closers without them accidentally deleted in xquery file while brainstorming; reinstated it.
joewiz
reviewed
Dec 3, 2021
joewiz
reviewed
Dec 3, 2021
joewiz
reviewed
Dec 3, 2021
joewiz
reviewed
Dec 3, 2021
joewiz
reviewed
Dec 3, 2021
joewiz
reviewed
Dec 3, 2021
joewiz
reviewed
Dec 3, 2021
fixes for errors noted by @joewiz
examples added for all update queries
... relieving us of the need for the local:reconstruct-node workaround. See https://www.w3.org/TR/xquery-31/#id-copy-namespaces-decl.
We'd deleted this previously, in favor of a rule that targeted the hi/@rend=strong element, but this was reinstated.
2 whitespace errors caught by new xquery updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix-signature-structure.xq and frus.sch checks ready for incorporation into master branch and application to other FRUS series. Reagan volumes have already been run through both.
New branch to be created for Carter subseries.