Makes horns less awful #442
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacogen
reviewed
Mar 10, 2017
|
|
||
| /obj/item/weapon/bikehorn/suicide_act(mob/user) | ||
| user.visible_message("<span class='suicide'>[user] solemnly points the horn at [user.p_their()] temple! It looks like [user.p_theyre()] trying to commit suicide!</span>") | ||
| playsound(src.loc, honksound, 50, 1) | ||
| return (BRUTELOSS) | ||
|
|
||
| /obj/item/weapon/bikehorn/attack(mob/living/carbon/M, mob/living/carbon/user) | ||
| if(!spam_flag) | ||
| if(next_honk < world.time) | ||
| playsound(loc, honksound, 50, 1, -1) //plays instead of tap.ogg! |
There was a problem hiding this comment.
don't you need next_honk = world.time + cooldowntime here as well?
There was a problem hiding this comment.
This is actually going to be affected by melee cooldown I think
There was a problem hiding this comment.
you can probably attack more often than the length of the sound
|
as much as i like the airhorn spam bug it has to go |
|
|
|
emagged horn has no limits |
|
fuk no |
|
stepping on airhorn honking is a good feature, otherwise i'm good with the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑 Tortellini Tony
fix: Reduced the ability to spam an airhorn or bikehorn.
/:cl:
First of all, how the hell does stepping on an airhorn make a noise?
https://images-na.ssl-images-amazon.com/images/I/61R%2BZDLuAfL.png
It's a can. It's made of metal. At least stepping on a bikehorn makes sense.
Made the cooldown time not use spawn(), and added the cooldown to stepping on a horn, so there is no functional difference between stepping on it and honking it.