Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions for correcting non-linear PMT signal #159

Closed
wants to merge 5 commits into from
Closed

Add functions for correcting non-linear PMT signal #159

wants to merge 5 commits into from

Conversation

153957
Copy link
Member

@153957 153957 commented Nov 5, 2016 •
edited
Loading

Add PMT saturation (also affected by ADC saturation) curve to signal_calibration module.
Allows for the correction of high signal values to the correct (higher) value.
Rename current calibration module to timing_calibration, since it only deals with timing issues.

Todo:

  • Provide good starting values for the parameters
  • Add tests for the new functions
  • Add function to fit data? (actually only good for fitting data with known inputs, i.e. KASCADE and LED tests)
  • Use this in reconstructions/processing (Correct particle count for PMT linearity #55)
  • Use this in simulations (Add PMT non linearity curve to simulation #97)
  • Determine PMT type per detector (over time):
    non-linear or new linear (still affected by ADC saturation)

Arne de Laat added 2 commits November 5, 2016 09:24
Add functions for correcting non-linear PMT signal
070bd78 
Signal calibration (correction) functions are in module
signal_calibration.
Rename calibration module to timing_calibration.
Fix PEP8 error in tests due to longer module name
6b670a1
@153957 153957 self-assigned this Jan 2, 2017
@153957 153957 removed their assignment Aug 17, 2017
@153957
Copy link
Member Author

153957 commented Aug 2, 2024

Merged by rebasing first; 835811e

@153957 153957 closed this Aug 2, 2024
@153957 153957 deleted the pmt-curve branch August 2, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@153957 @tomkooij