refactor(contributors): use explicit is_month for tab activation

Replaced the 'not is_week' condition with a more explicit 'is_month' for better code clarity and maintainability.
Hexlet · Aug 15, 2023 · 6d658cd · 6d658cd
1 parent 7097d56
commit 6d658cd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/contributors/views/contributors_for_period.py b/contributors/views/contributors_for_period.py
@@ -14,6 +14,7 @@ def get_context_data(self, **kwargs):
         context = super().get_context_data(**kwargs)
         context['dt_month_ago'] = misc.datetime_month_ago()
         context['is_week'] = self.extra_context.get('period') == 'week'
+        context['is_month'] = self.extra_context.get('period') == 'month'
         return context
 
     def get_queryset(self):  # noqa: WPS615

diff --git a/templates/components/time_note.html b/templates/components/time_note.html
@@ -2,12 +2,14 @@
 
 <ul class="nav nav-pills">
   <li class="nav-item">
-      <a class="nav-link time-note py-1 {% if is_week %}active{% endif %}" href="{% url 'contributors:contributors_for_week' %}" name="top-week">
+      <a class="nav-link time-note py-1 {% if is_week %}active{% endif %}"
+         href="{% url 'contributors:contributors_for_week' %}" name="top-week">
           {% trans "for the past week" %}
       </a>
   </li>
   <li class="nav-item">
-      <a class="nav-link time-note py-1 {% if not is_week %}active{% endif %}" href="{% url 'contributors:contributors_for_month' %}" name="top-month">
+      <a class="nav-link time-note py-1 {% if is_month %}active{% endif %}"
+         href="{% url 'contributors:contributors_for_month' %}" name="top-month">
           {% trans "for the past month" %}
       </a>
   </li>