Fix resume state transitions

app/controllers/web/account/resumes_controller.rb

@@ -19,7 +19,8 @@ def create
     @resume = Web::Account::ResumeForm.new(params[:resume])
     @resume.user = current_user
 
-    if @resume.save && change_visibility(@resume)
+    change_state(@resume)
+    if @resume.save
       OpenAiJob.perform_later(@resume.id)
       f(:success)
       redirect_to account_resumes_path
@@ -33,13 +34,8 @@ def update
     resume = current_user.resumes.find params[:id]
     @resume = resume.becomes(Web::Account::ResumeForm)
 
-    if params[:publish]
-      @result = ResumeMutator.publish!(@resume, params[:resume])
-    elsif params[:hide]
-      @result = ResumeMutator.to_draft!(@resume, params[:resume])
-    end
-
-    if @result
+    change_state(@resume)
+    if @resume.update(params[:resume])
       OpenAiJob.perform_later(@resume.id)
       f(:success)
       redirect_to account_resumes_path
@@ -53,9 +49,11 @@ def destroy; end
 
   private
 
-  def change_visibility(resume)
-    return resume.publish! if params[:publish]
-
-    resume.hide! if params[:hide]
+  def change_state(resume)
+    if params[:publish]
+      resume.publish
+    else
+      resume.hide
+    end
   end
 end

test/controllers/web/account/resumes_controller_test.rb

@@ -67,6 +67,23 @@ class Web::Account::ResumesControllerTest < ActionDispatch::IntegrationTest
     assert { resume.not_evaluated? }
   end
 
+  test '#create unfilled and fail to publish' do
+    attrs = {
+      name: 'Ruby developer'
+    }
+
+    params = {
+      publish: true,
+      resume: attrs
+    }
+
+    post(account_resumes_path, params:)
+    assert_response :unprocessable_entity
+
+    resume = Resume.find_by(name: attrs[:name])
+    assert { !resume }
+  end
+
   test '#update evaluated_ai_state failed' do
     resume = resumes(:one_evaluated_failed)
     attrs = FactoryBot.attributes_for(:resume)