Skip to content

Commit

Permalink
add user removing (wip)
Browse files Browse the repository at this point in the history
  • Loading branch information
chrtkv committed Apr 11, 2024
1 parent 11f9099 commit d556788
Show file tree
Hide file tree
Showing 10 changed files with 47 additions and 4 deletions.
10 changes: 10 additions & 0 deletions app/controllers/web/account/profiles_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,16 @@ def update
end
end

def destroy
UserService.remove!(current_user)
sign_out
f(:success)
redirect_to root_path
rescue StandardError
f(:error)
redirect_to edit_account_profile_path
end

private

def profile_params
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/web/users_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def index
end

def show
@user = User.find(params[:id])
@user = User.permitted.find(params[:id])
@user_resume_answers = @user.resume_answers.web
@user_resume_answers_likes_count = @user.resume_answers.sum('likes_count')
@user_resumes = @user.resumes.web
Expand Down
14 changes: 13 additions & 1 deletion app/models/user.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class User < ApplicationRecord
include UserRepository
include UserPresenter

validates :email, 'valid_email_2/email': true
validates :email, 'valid_email_2/email': true, if: :email_required?

# https://github.com/heartcombo/devise/wiki/How-To:-Add-an-Admin-Role
enumerize :role, in: %i[user admin], default: :user, predicates: true, scope: true
Expand All @@ -32,6 +32,7 @@ class User < ApplicationRecord
aasm :state, column: :state do
state :permitted, initial: true
state :banned
state :removed

event :ban do
transitions from: %i[permitted], to: :banned
Expand All @@ -40,6 +41,10 @@ class User < ApplicationRecord
event :unban do
transitions from: %i[banned], to: :permitted
end

event :remove do
transitions to: :removed
end
end

# https://github.com/heartcombo/devise/wiki/How-to:-Soft-delete-a-user-when-user-deletes-account
Expand Down Expand Up @@ -99,6 +104,13 @@ def self.ransackable_associations(_auth_object = nil)
%w[resumes careers career_members]
end

protected

# NOTE: override Devise method
def email_required?
!removed?
end

# NOTE: https://github.com/plataformatec/devise#activejob-integration
# def send_devise_notification(notification, *args)
# devise_mailer.send(notification, self, *args).deliver_later
Expand Down
3 changes: 3 additions & 0 deletions app/views/web/account/profiles/edit.html.slim
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,6 @@
= t('.header')

= render 'form', user: @user

.mt-5
= link_to t('.remove'), account_profile_path, class: 'btn btn-danger', method: :delete, data: { confirm: t('.confirm_remove') }
3 changes: 3 additions & 0 deletions config/locales/en.flash.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ en:
profiles:
update:
success: Data updated
destroy:
success: Your account has been deleted
error: Failed to delete account. Please reach out to our support team via [email protected]
resumes:
update:
success: Resume updated
Expand Down
3 changes: 3 additions & 0 deletions config/locales/ru.flash.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ ru:
update:
success: Данные обновлены
error: Не удалось обновить данные
destroy:
success: Ваш аккаунт удалён
error: Не удалось удалить аккаунт. Обратитесь в поддержку [email protected]
resumes:
update:
success: Резюме обновлено
Expand Down
2 changes: 2 additions & 0 deletions config/locales/ru.views.yml
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,8 @@ ru:
info_for_user: Давайте познакомимся =). Заполните, пожалуйста, фамилию, имя и можете рассказать немного о себе.
edit:
header: Настройки
remove: Удалить аккаунт
confirm_remove: Вы уверены, что хотите удалить свой аккаунт?
show:
header: Мой профиль
edit_profile: Редактировать профиль
Expand Down
2 changes: 1 addition & 1 deletion config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
resources :vacancies
resources :notifications, only: %i[index update]
resource :newsletters, only: %i[edit update]
resource :profile, only: %i[edit update]
resource :profile, only: %i[edit update destroy]
scope module: :careers do
resources :members, only: %i[index]
end
Expand Down
2 changes: 1 addition & 1 deletion db/schema.rb
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@
t.string "last_name"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.string "encrypted_password", default: "", null: false
t.string "encrypted_password"
t.string "reset_password_token"
t.datetime "reset_password_sent_at", precision: nil
t.datetime "remember_created_at", precision: nil
Expand Down
10 changes: 10 additions & 0 deletions test/controllers/web/account/profiles_controller_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,14 @@ class Web::Account::ProfilesControllerTest < ActionDispatch::IntegrationTest
patch account_profile_path(user, locale: I18n.locale), params: { web_account_profile_form: attrs }
assert_response :redirect
end

test 'destroy' do
delete account_profile_path
assert_response :redirect

@user.reload

assert { @user.removed? }
# TODO: add signed out checking
end
end

0 comments on commit d556788

Please sign in to comment.