Add --export-variables and --escape-json
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AislingHPE
force-pushed
the
add-export-variables
branch
from
e28b395 to
a8a17b3
Compare
AislingHPE
force-pushed
the
debug-logging
branch
from
6d1dab4 to
addf9af
Compare
AislingHPE
force-pushed
the
add-export-variables
branch
from
a8a17b3 to
0ff21b7
Compare
AislingHPE
force-pushed
the
debug-logging
branch
from
addf9af to
bdb8ea0
Compare
AislingHPE
force-pushed
the
add-export-variables
branch
from
0ff21b7 to
174a3b1
Compare
AislingHPE
force-pushed
the
add-export-variables
branch
2 times, most recently
from
13df74e to
2b0b41b
Compare
AislingHPE
force-pushed
the
add-export-variables
branch
from
2b0b41b to
1484da1
Compare
Also move some code to the reader package, since it is needed by the new json package. This returns a JSON blob of the variables with behaviour described in the README file. I also disabled the default behaviour of Go where it escapes certain characters for HTML reasons because I don't think it will be needed here in the majority of cases, and it makes the condition statements harder to read if you're not using a special app like jq.
AislingHPE
force-pushed
the
add-export-variables
branch
from
1484da1 to
48fb546
Compare
stuart-mclaren-hpe
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move some code to the reader package, since it is needed by the new
jsonpackage.This returns a JSON blob of the variables with behaviour described in the README file. I also disabled the default behaviour of Go where it escapes certain characters for HTML reasons because I don't think it will be needed here in the majority of cases, and it makes the condition statements harder to read if you're not using a special app like
jq.The reason i want to add this is because it contains some of the intermediate information I use in the test cases, and making it part of the CLI will allow me to generate that test data more easily.