Add make test-data

This will be used for creating more unit tests, and allows for automatically regenerating schema files when code changes.

.gitattributes

@@ -0,0 +1 @@
+test/expected/*/*.json linguist-generated=true

Makefile

@@ -18,4 +18,13 @@ terraschema:
 
 .PHONY: clean
 clean:
-	@rm -f terraschema
+	@rm -f terraschema
+
+.PHONY: test-data
+test-data:
+	@for name in `ls test/modules`; do \
+		go run . -i test/modules/$$name -o test/expected/$$name/schema.json --overwrite --allow-empty; \
+		go run . -i test/modules/$$name -o test/expected/$$name/variables.json --overwrite --allow-empty --export-variables; \
+		go run . -i test/modules/$$name -o test/expected/$$name/schema-disallow-additional.json --overwrite --allow-empty --disallow-additional-properties; \
+		go run . -i test/modules/$$name -o test/expected/$$name/schema-nullable-all.json --overwrite --allow-empty --nullable-all; \
+	done

pkg/jsonschema/json-schema.go

@@ -64,6 +64,7 @@ func CreateSchema(path string, options CreateSchemaOptions) (map[string]any, err
 	return schemaOut, nil
 }
 
+//nolint:cyclop
 func createNode(name string, v model.TranslatedVariable, options CreateSchemaOptions) (map[string]any, error) {
 	tc, err := reader.GetTypeConstraint(v.Variable.Type)
 	if err != nil {
@@ -115,6 +116,12 @@ func createNode(name string, v model.TranslatedVariable, options CreateSchemaOpt
 		node["description"] = *v.Variable.Description
 	}
 
+	// if nullable is true, then we need to unset the definition for "type" here, since it was only added to
+	// satisfy the validation rules and is not actually a part of the schema.
+	if nullableTranslatedValue {
+		delete(node, "type")
+	}
+
 	return node, nil
 }
 

pkg/jsonschema/type.go

@@ -55,6 +55,10 @@ func getNullableNode(name string, typeInterface any, options CreateSchemaOptions
 	}
 	node["title"] = fmt.Sprintf("%s: Select a type", name)
 
+	// this is here until the validation rules are applied, because otherwise they error since "type" is undefined.
+	// This sets validation to apply to the top level, which implies that validation must pass even if the value is null.
+	node["type"] = internalNode["type"]
+
 	return node, nil
 }
 

pkg/jsonschema/validation.go

@@ -24,7 +24,7 @@ func parseConditionToNode(ex hcl.Expression, _ string, name string, m *map[strin
 	}
 	t, ok := (*m)["type"].(string)
 	if !ok {
-		return fmt.Errorf("cannot apply validation, type is not defined for %#v", *m)
+		return fmt.Errorf("cannot apply validation, type is not defined for %v", *m)
 	}
 	functions := map[string]conditionMutator{
 		"contains([...],var.input_parameter)":          contains,