Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lig coverage #693

Merged
merged 38 commits into from
May 6, 2021
Merged

Lig coverage #693

merged 38 commits into from
May 6, 2021

Conversation

yuvirani
Copy link
Collaborator

@yuvirani yuvirani commented May 5, 2021

Description

Lig coverage

Issues Resolved

[#669]

Check List

  • New functionality includes testing.
    • All tests pass. ($ ./build.sh).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • The PR changes have been added to ansible-collections.

@@ -203,7 +328,7 @@
mode: 'Auto'
networkType: 'Ethernet'
networkNames:
- 'TestNetwork_3'
- 'TestNetwork_5'
# - '/rest/ethernet-networks/5cca6ddc-49b1-4c7c-9022-eadb2630d42b'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this commented lines under NetworkNames

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@VenkateshRavula VenkateshRavula self-requested a review May 6, 2021 07:46
Copy link
Collaborator

@VenkateshRavula VenkateshRavula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove deepdiff from requirements.txt file

@yuvirani
Copy link
Collaborator Author

yuvirani commented May 6, 2021

remove deepdiff from requirements.txt file

Done

@yuvirani yuvirani merged commit c375299 into master May 6, 2021
@yuvirani yuvirani deleted the LIG_Coverage branch May 6, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants