Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snmp user facts changes #649

Merged
merged 12 commits into from
Mar 2, 2021
Merged

Added snmp user facts changes #649

merged 12 commits into from
Mar 2, 2021

Conversation

nabhajit-ray
Copy link
Collaborator

Description

[Added snmp user facts changes]

Issues Resolved

[List any issues this PR will resolve. e.g., Fixes #1]

Check List

  • New functionality includes testing.
    • All tests pass. ($ ./build.sh).
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).

@@ -31,9 +31,9 @@
config='config.json'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change copyright year

@@ -68,8 +68,9 @@ def test_should_get_all_snmp_v3_users(self):
)

def test_should_get_by_id_snmp_v3_users(self):
Copy link
Collaborator

@VenkateshRavula VenkateshRavula Mar 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change test case name to test_should_get_by_name_snmp_v3_users

@VenkateshRavula
Copy link
Collaborator

Also update this resource in CHANGELOG and endpoints file

@@ -44,7 +44,7 @@
hostname: 172.16.101.48
username: administrator
password: my_password
api_version: 800
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change hpeOneView version to 6.0.0

Copy link
Collaborator

@AsisBagga AsisBagga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabhajit-ray nabhajit-ray merged commit ed8dc24 into master Mar 2, 2021
@VenkateshRavula VenkateshRavula deleted the refactored_snmp_usersv3 branch March 22, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This repo is private, when will be public?
3 participants