time_and_locale_branch #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kard/oneview-ansible into time_and_locale_branch
AsisBagga
reviewed
Mar 2, 2021
|
|
||
|
|
||
| class ApplianceTimeAndLocaleConfigurationModule(OneViewModuleBase): | ||
| MSG_UPDATED = 'Appliance Locale and Time Configuration updated successfully.' |
There was a problem hiding this comment.
missing Update Msg, does this resource do not have PUT/PATCH Operation?
added_timeconfig_and_documentation
yuvirani
reviewed
Mar 2, 2021
| @@ -80,8 +81,19 @@ def __init__(self): | |||
| self.resource_client = self.oneview_client.appliance_time_and_locale_configuration | |||
There was a problem hiding this comment.
Use set_resource_object method as we follow the same part of refactoring
yuvirani
reviewed
Mar 2, 2021
| author: | ||
| "Thiago Miotto (@tmiotto)" | ||
| "Shanmugam M (@SHANDCRUZ)" | ||
| extends_documentation_fragment: | ||
| - oneview |
nabhajit-ray
approved these changes
Mar 2, 2021
added_ssh_access
| short_description: Retrieve the facts about the OneView appliance time configuration. | ||
| description: | ||
| - Retrieve the facts about the OneView appliance time configuration. | ||
| version_added: "2.4" |
There was a problem hiding this comment.
change version to "2.9". This is the ansible version.
| version_added: "2.4" | ||
| requirements: | ||
| - "python >= 3.4.2" | ||
| - "hpeOneView >= 5.6.0" |
There was a problem hiding this comment.
change hpeOneView >= 6.0.0.
Follow the same for all resources
| def execute_module(self): | ||
| changed, msg, ansible_facts = False, '', {} | ||
| appliance_ssh_access = self.resource_client.get_all() | ||
| self.current_resource = appliance_ssh_access |
There was a problem hiding this comment.
directly assign self.resource_client.get_all() to self.current_resource
| class ApplianceTimeAndLocaleConfigurationModule(OneViewModuleBase): | ||
| MSG_UPDATED = 'Appliance Locale and Time Configuration updated successfully.' | ||
| class ApplianceTimeAndLocaleConfigurationModule(OneViewModule): | ||
| MSG_CREATED = 'Appliance Locale and Time Configuration created successfully.' |
There was a problem hiding this comment.
modify the message to avoid confusion
MSG_CREATED = 'Appliance Locale and Time Configuration configured successfully.'
|
|
||
| def __present(self): | ||
| self.current_resource = self.resource_client.get_all() | ||
| merged_data = self.current_resource.data.copy() |
There was a problem hiding this comment.
what if the return value of self.resource_client.get_all() is None..?
self.current_resource.data.copy() value will fail saying None type has no 'data' attribute. So add the if condition before that.
…kard/oneview-ansible into added_time_and_locale
| self.current_resource = self.resource_client.create(self.data) | ||
| return True, self.MSG_CREATED, dict(appliance_time_and_locale_configuration=self.current_resource.data) | ||
| else: | ||
| return False, self.MSG_ALREADY_PRESENT, dict(appliance_time_and_locale_configuration=self.current_resource.data) |
There was a problem hiding this comment.
try the below code
def __present(self):
resource_data = {}
self.current_resource = self.resource_client.get_all()
if self.current_resource:
resource_data = self.current_resource.data.copy()
merged_data = resource_data.copy()
merged_data.update(self.data)
if not compare(resource_data, merged_data):
self.current_resource = self.resource_client.create(self.data)
return True, self.MSG_CREATED, dict(appliance_time_and_locale_configuration=self.current_resource.data)
else:
return False, self.MSG_ALREADY_PRESENT, dict(appliance_time_and_locale_configuration=resource_data)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored Appliance Time and Locale Configuration
Issues Resolved
None
Check List
$ ./build.sh).