Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEC support for Emulationstation #38

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

kubax
Copy link

@kubax kubax commented Jun 10, 2016

First of all. It's not my work!

The patch to implement libCEC to Emulationstation is done by https://github.com/CeRiAl/EmulationStation

Only thing i did was cherry-picking the commits to bring the commits to the latest git from you, make it compatible to libCEC3 (also borrowed from https://github.com/fkmclane/overlay/blob/master/media-tv/plex-home-theater/files/libcec.patch) and restructuring the code to make it run even without a working CEC adapter.

Sadly i'm at work, and couldn't test the CEC part, but i'll post soon if it works and let you know. Just wanted to don't forget to post the PR :)

@kubax
Copy link
Author

kubax commented Jun 10, 2016

Just to let you know, it's tested, and the CEC part seems to work (it didn't at first, but it seems that the Pule eight USB Adapter can only be used by one Program, and that was Kodi at this point).

So everything seems fine :) (except i have to find another way to have kodi start emulationstation and have it controlled with the remote...)

@escalade
Copy link

I see there's a fix in there, but it still segfaults for me when launching a game (no CEC adapter).

@kubax
Copy link
Author

kubax commented Jun 22, 2016

Oh, might be possible i didn't check if it actually launces games. I'll investigate in this this evening and give it a try.

@kubax
Copy link
Author

kubax commented Jun 22, 2016

Pushed a fix for the crash.
Problem seemed to be cause by to early unloading cec adapter and later trying it again.

@escalade
Copy link

Now it crashes when returning to ES after game exit.

@kubax
Copy link
Author

kubax commented Jun 23, 2016

For the moment i#m not in reach of an linux system. But i'll investigate in this tomorrow or monday (depends on when i'm in reach of one) but i didn't had this problem.. if reproducable could you add a backtrace from gdb. it might be possible that i can fix it without getting in reach of a linux box.

@escalade
Copy link

Sorry, I'm not a developer so that's beyond my skillset :) Do I just run gdb with emulationstation as an argument, or?

@kubax
Copy link
Author

kubax commented Jun 23, 2016

basically it's

gdb ../emulationstation (when you are in the build directory)
r (to run the programm
when crash occours "bt" to backtrace. and i'm neither, those are the only two commands i know from gdb ;)

@kubax
Copy link
Author

kubax commented Jun 27, 2016

So i tested, and couldn't reproduce your problem.. could you please attach a backtrace?

@escalade
Copy link

Been busy last few days, but will do so when I get some time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants