Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial implementation of cluster-modelling features #38

Merged
merged 26 commits into from
Nov 6, 2024
Merged

Conversation

aymgal
Copy link
Member

@aymgal aymgal commented Nov 6, 2024

This PR implements features useful to model galaxy clusters, such as the dPIE profile, a parser for GLEE models, and partial integration of the new multi-plane classes.

After this merge, this branch (dev-cluster-model) will focus solely on continuous developments regarding cluster-scale modelling, and a new PR will be opened to finalize the proper integration of the multi-plane classes within the Herculens class hierarchy.

aymgal added 26 commits July 31, 2024 22:52
…'s deflection function (TODO: apply this to other class methods)
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11707072587

Details

  • 57 of 640 (8.91%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.1%) to 21.405%

Changes Missing Coverage Covered Lines Changed/Added Lines %
herculens/LensImage/lens_image.py 1 13 7.69%
herculens/MassModel/mass_model.py 19 37 51.35%
herculens/MassModel/mass_model_multiplane.py 0 36 0.0%
herculens/MassModel/Profiles/dpie.py 37 99 37.37%
herculens/LensImage/lens_image_future.py 0 100 0.0%
herculens/Util/glee_util.py 0 355 0.0%
Files with Coverage Reduction New Missed Lines %
herculens/MassModel/mass_model.py 1 45.28%
Totals Coverage Status
Change from base Build 11700989694: -1.1%
Covered Lines: 1584
Relevant Lines: 7400

💛 - Coveralls

@aymgal aymgal merged commit a15896a into main Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants