Draft of upstream specific stats on cluster #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach:
General questions:
Unfortunately I see some weird behavior in client_impl_test with histogram stats. I'm not sure if it's an issue with my code ie additions to cluster mock, or if I am misunderstanding how to test that histograms are fired:
Limitations:
client_impl_test.cc
running and adding the new fieldRunning tests:
$ bazel test -c dbg //test/extensions/filters/network/common/redis:client_impl_test --cache_test_results=no --test_output=all --test_filter=*CommandStats*